[Maverick SRU] (pre-stable) Fix mic for Dell Vostro 320
david.henningsson at canonical.com
Sun Jan 2 08:59:20 UTC 2011
On 2010-12-10 21:54, Tim Gardner wrote:
> On 12/10/2010 08:38 AM, Brad Figg wrote:
>> On 12/10/2010 06:19 AM, Stefan Bader wrote:
>>> On 12/10/2010 12:57 PM, David Henningsson wrote:
>>>> SRU Justification:
>>>> Impact: Non-working mic
>>>> Fix: Quirk into model "ideapad", tested by cert lab
>>>> Testcase: Try recording from mic
>>>> Upstream status: Not yet reached Linus's tree, commit id in Takashi's
>>>> tree is 8a96b1e02029aa512199b1b6d281dcede9ed81f1.
>>>> Hope I did everything right this time :-)
>>> I am afraid, no. :-P The BugLink is invalid and should be:
>>> Patch looks reasonable. Arguable whether we should wait to apply it
>>> until it has
>>> at least made it into Linus tree. It is not a critical issue. On the
>>> other hand
>>> it is simple enough and very limited in scope.
It has now reached Linus's tree.
>>> Acked-by: Stefan Bader<stefan.bader at canonical.com>
>> It's early so I might have missed it but the SRU text is missing from the
>> bug. Just adding it as a comment is acceptable, some folks modify the
>> bug description and add it there.
(although my personal opinion is that this is just extra bureaucracy).
>> The patch looks fine however.
>> Acked-by: Brad Figg<brad.figg at canonical.com>
> And while you're fixing the commit log, reformat the patch so that it
> applies to Maverick.
Attaching modified patch. Checked that buglink is correct and that it
applies to ubuntu-maverick.
David Henningsson, Canonical Ltd.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1371 bytes
Desc: not available
More information about the kernel-team