Oneiric: [PATCH] (UBUNTU: Sauce) Match jack input devices and pcm devices for HDMI

[Tim Gardner]

On 08/30/2011 12:21 AM, David Henningsson wrote:
> On 08/29/2011 06:08 PM, Tim Gardner wrote:
>> On 08/29/2011 08:52 AM, David Henningsson wrote:
>>> Upstream status for this patch is that Takashi went on vacation before
>>> he commented on the patch, and might not return before kernel freeze.
>>>
>>> Anyway, it's needed for jack detection for HDMI to work. So I'd be happy
>>> if we could apply this for Oneiric (the jack detection patches are
>>> distro patches anyway), and then I'll have plenty of time to sort out
>>> with Takashi what to do for P.
>>>
>>
>> While the patch looks fine, its difficult for me to ascertain the risk
>> of regression. Has this patch had widespread testing? It appears to have
>> the possibility for widespread impact.Without some really warm fuzzies
>> from you (and a little data to back your claim), I'm inclined to let
>> this go through the normal upstream process.
>
> I'm not sure exactly what "warm fuzzies" you need, but currently:
>
> * It has not had widespread testing. I could obviously test it on all
> machines I have here, something I should probably do anyway, but would
> that be enough for you?
>
> * The upstream version of this patch, for Linux 3.2 (which is slightly
> different, this is a backported version) has received review from
> Stephen Warren at Nvidia, who has recently refactored the HDMI audio
> driver. He believes the patch looks good, but was unsure if he wanted
> more reformatting of the string at the same time.
>

So, you're asking to have a patch applied that has general impact on all 
platforms with an HDMI port, which by your own admission has not had 
widespread testing, and has not been agreed to or fully reviewed by 
upstream maintainers.

The kernel is in Beta freeze right now. What would your call be if you 
were in the same position?

rtg
-- 
Tim Gardner tim.gardner at canonical.com