[Hardy CVE-2011-0711] xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1, CVE-2011-0711
Leann Ogasawara
leann.ogasawara at canonical.com
Wed Apr 20 21:48:10 UTC 2011
The following changes since commit 62419a42fd4f8a418e90ca0d474eae77c138152e:
Tim Gardner (1):
UBUNTU: [Config] remove generated files
are available in the git repository at:
git://kernel.ubuntu.com/ogasawara/ubuntu-hardy.git CVE-2011-0711
Dan Rosenberg (1):
xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1, CVE-2011-0711
fs/xfs/xfs_fsops.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
>From 147f4ed49f1fe360bc61ebea34496bcca3dc4c85 Mon Sep 17 00:00:00 2001
From: Dan Rosenberg <drosenberg at vsecurity.com>
Date: Mon, 14 Feb 2011 13:45:28 +0000
Subject: [PATCH] xfs: prevent leaking uninitialized stack memory in FSGEOMETRY_V1, CVE-2011-0711
BugLink: http://bugs.launchpad.net/bugs/767740
CVE-2011-0711
The FSGEOMETRY_V1 ioctl (and its compat equivalent) calls out to
xfs_fs_geometry() with a version number of 3. This code path does not
fill in the logsunit member of the passed xfs_fsop_geom_t, leading to
the leaking of four bytes of uninitialized stack data to potentially
unprivileged callers.
v2 switches to memset() to avoid future issues if structure members
change, on suggestion of Dave Chinner.
Signed-off-by: Dan Rosenberg <drosenberg at vsecurity.com>
Reviewed-by: Eugene Teo <eugeneteo at kernel.org>
Signed-off-by: Alex Elder <aelder at sgi.com>
(cherry picked from commit 3a3675b7f23f83ca8c67c9c2b6edf707fd28d1ba)
Signed-off-by: Leann Ogasawara <leann.ogasawara at canonical.com>
---
fs/xfs/xfs_fsops.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/fs/xfs/xfs_fsops.c b/fs/xfs/xfs_fsops.c
index c92d5b8..e6d08b0 100644
--- a/fs/xfs/xfs_fsops.c
+++ b/fs/xfs/xfs_fsops.c
@@ -56,6 +56,9 @@ xfs_fs_geometry(
xfs_fsop_geom_t *geo,
int new_version)
{
+
+ memset(geo, 0, sizeof(*geo));
+
geo->blocksize = mp->m_sb.sb_blocksize;
geo->rtextsize = mp->m_sb.sb_rextsize;
geo->agblocks = mp->m_sb.sb_agblocks;
--
1.7.0.4
More information about the kernel-team
mailing list