[PATCH][Upstream] USB: Add ids of SamsungYP-M1 to restrict max sector

[Brad Figg]

On 04/30/2010 02:44 AM, Stefan Bader wrote:
> Andy Whitcroft wrote:
>> On Wed, Apr 07, 2010 at 03:59:36PM +0300, Surbhi Palande wrote:
>>> This quirk fixes bug 503790 on launchpad where a user complained of having to
>>> manually set the max sectors for a USB thumb drive to make it work. This small
>>> quirk sets the sector size explicitly in the kernel code. This patch is tested
>>> by the reporter of the bug. Do consider merging this for Lucid.
>>>
>>>  From 13a918b7c5917a702f14eaa938f10194417482ba Mon Sep 17 00:00:00 2001
>>> From: Surbhi Palande<surbhi.palande at canonical.com>
>>> Date: Fri, 19 Mar 2010 15:58:29 +0200
>>> Subject: [PATCH] USB: Add ids of SamsungYP-M1 to restrict max sectors
>>>
>>> http://launchpad.net/bugs/503790
>>>
>>> The Samsung YP-M1 does not work unless the following is done manually "echo
>>> 128>  /sys/block/sdb/device/max_sectors" as root. This quirk fixes having to
>>> do this manually.
>>>
>>> BugLink: http://launchpad.net/bugs/lp503790
>>>
>>> Signed-off-by: Surbhi Palande<surbhi.palande at canonical.com>
>>> ---
>>>   drivers/usb/storage/unusual_devs.h |    7 +++++++
>>>   1 files changed, 7 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
>>> index f6ab789..6469673 100644
>>> --- a/drivers/usb/storage/unusual_devs.h
>>> +++ b/drivers/usb/storage/unusual_devs.h
>>> @@ -133,6 +133,13 @@ UNUSUAL_DEV(  0x0419, 0xaace, 0x0100, 0x0100,
>>>   		US_SC_DEVICE, US_PR_DEVICE, NULL,
>>>   		US_FL_IGNORE_RESIDUE ),
>>>
>>> +/* Reported by Surbhi Palande<surbhi.palande at canonical.com>  */
>>> +UNUSUAL_DEV(  0x04e8, 0x5123, 0x0000, 0x0000,
>>> +		"Samsung",
>>> +		"YP-M1",
>>> +		US_SC_DEVICE, US_PR_DEVICE, NULL,
>>> +		US_FL_MAX_SECTORS_64),
>>> +
>>
>> I thought that these entries were in id order?  Could you confirm and if
>> so move it to the right place :).
>>
>
> There has not been any response to this. Surbhi, if the other quirks are
> ordered, could you resend a patch that inserts it into the right place?
>
> Stefan
>
>>>   /* Reported by Christian Leber<christian at leber.de>  */
>>>   UNUSUAL_DEV(  0x0419, 0xaaf5, 0x0100, 0x0100,
>>>   		"TrekStor",
>>
>> -apw
>>
>
>

Surbhi,

Please resubmit this patch if it is still relevant, addressing the issues
others have mentioned.

Brad
-- 
Brad Figg brad.figg at canonical.com http://www.canonical.com