[Maverick] SRU: Fixes for coretemp and pkgtemp

Zhao, Yingying yingying.zhao at intel.com
Wed Oct 20 03:17:40 UTC 2010


AFAIK, these commits on coretmp are not submitted to stable. 
Yes, as you said the patch(89a3fd35) depends on those two patch (0dca94b and 851b29c). Another commit 3771330 [1] which is a fix for commit 851b29c is also necessary. 
Most of the fixes on coretemp after v2.6.35 are about hotplug support, I'd suggest to apply all the commits from 0dca94b to fff2017. What's your opinion?

Thanks,
Yingying

-----Original Message-----
From: Leann Ogasawara [mailto:leann.ogasawara at canonical.com] 
Sent: Thursday, October 14, 2010 6:14 AM
To: Zhao, Yingying
Cc: Ubuntu Kernel Team
Subject: Re: [Maverick] SRU: Fixes for coretemp and pkgtemp

Hi Yingying,

Just curious if these have been submitted to upstream stable as well?
Additional comments inlined below...

On Sat, 2010-10-09 at 16:28 +0800, Zhao, Yingying wrote:
> BugLink: http://bugs.launchpad.net/bugs/601073
>  
> SRU Justification:
> The following commits fix some coretemp/pkgtemp bugs, please consider
> to apply them to Maverick.
>  
> commit 89a3fd35ba0318a7208e2c8d8ca6189f567d4a93
> x86/hwmon: fix module init for hotplug-but-no-device-found case

It seems the above fix is dependent on having applied the following
commit.  However, we don't have the following commit applied in
Maverick.  So I assume we want this patch as well? 

commit 0dca94baeab4a1a514841b0a4c8e3a51dfb4d5ae
Author: Chen Gong <gong.chen at linux.intel.com>
Date:   Mon Aug 9 17:21:09 2010 -0700

    hwmon: coretemp: update hotplug condition check

It also appears that it would be beneficial to add the following as
well.  Should this also be considered?

commit 851b29cb3b196cb66452ec964ab5f66c9c9cd1ed
Author: Chen Gong <gong.chen at linux.intel.com>
Date:   Mon Aug 9 17:21:10 2010 -0700

    hwmon: coretemp: enable coretemp device add operation failure

By adding the additional two patches noted above, this allows for clean
cherry-picks of all the commits with the exception of a4659053 (which is
a simple manual fix up).

Thanks,
Leann

> commit d172132f358552eabd7a7410e478ffeead445243
> x86/hwmon: don't leak device attribute file from pkgtemp_probe() and
> pkgtemp_remove()
>  
> commit d9bca4358286584cc22f4261ee3a60cad01aa4d4
> x86/hwmon: avoid deadlock on CPU removal in pkgtemp
>  
> commit a46590533ad7b0f3f640732081d7e1658145c0ba
> x86/hwmon: fix initialization of coretemp
>  
> commit f6aeccdb96fc0555e939dd507702922f07dcbcbb
> x86/hwmon: fix initialization of pkgtemp
>  
> commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f
> x86/hwmon: register alternate sibling upon CPU removal
>  
> commit 0eae7799000cdf0c2ed596c39bfb71030809fc71
> x86/hwmon: pkgtemp has no dependency on PCI
>  
> Thanks,
> Yingying
>  




More information about the kernel-team mailing list