[PATCH] dell-laptop: defer dell_rfkill_update to worker thread

Chase Douglas chase.douglas at canonical.com
Mon May 17 18:52:58 UTC 2010


On Fri, Apr 16, 2010 at 10:06 AM, Andy Whitcroft <apw at canonical.com> wrote:
> On Mon, Apr 12, 2010 at 05:04:38PM +0100, Matthew Garrett wrote:
>> On Mon, Apr 12, 2010 at 04:20:42PM +0200, Stefan Bader wrote:
>> > Am I correct in assuming, this is intended for upstreaming? Will you propose
>> > stable when submitting it?
>>
>> This ought to be already fixed in upstream. The broken code was never in
>> a mainline release. As an aside, it would be nice to get some more
>> upstream involvement in this - I've dug out and incorporated the SAUCE
>> patches that seem to make sense, but it'd be nice to have them mailed to
>> me instead!
>
> Hmmm I had assumed that Mario was going to be pushing the whole lot
> upstream as well.  I am planning on a sweep of our delta pushing up the
> sane bits shortly as well.

I went and checked upstream to find out if it was using a work queue
to handle this already as Matthew thought. Of course, he was correct:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=814cb8adbe2fb49302ac65bc31fa749143823860

It looks like our Maverick kernel code for this driver is based on
upstream and not on Lucid, so we should be good going forward.
Hopefully this snafu won't happen again. Matthew, thanks for bringing
this to our attention!

-- Chase




More information about the kernel-team mailing list