[PATCH] UBUNTU: SAUCE: acpi: video: fix acpi_backlight=video

Chase Douglas chase.douglas at canonical.com
Sat May 1 19:43:22 UTC 2010

On Sat, May 1, 2010 at 3:11 PM, Kamal Mostafa <kamal at canonical.com> wrote:
> Make "acpi_backlight=video" param enable ACPI_VIDEO_BACKLIGHT_FORCE_VIDEO
> as intended, instead of incorrectly enabling video output switching.
> BugLink: http://bugs.launchpad.net/bugs/573120
> Signed-off-by: Kamal Mostafa <kamal at canonical.com>
> ---
>  drivers/acpi/video_detect.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index fc2f26b..c5fef01 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -250,7 +250,7 @@ static int __init acpi_backlight(char *str)
>                                ACPI_VIDEO_BACKLIGHT_FORCE_VENDOR;
>                if (!strcmp("video", str))
>                        acpi_video_support |=
> -                               ACPI_VIDEO_OUTPUT_SWITCHING_FORCE_VIDEO;
> +                               ACPI_VIDEO_BACKLIGHT_FORCE_VIDEO;
>        }
>        return 1;
>  }
> --

Since this is post-release and not a kitten-killer, it should probably
come directly from the stable tree. At the very least, it should be
accepted upstream (hopefully in Linus' tree, but at least in the acpi
tree) before we take it in. This is better overall for our maintenance
in case the patch is faulty, and for the greater Linux community.

If you think this should be included in 10.04 as a pre-stable patch, I
think it should be resent with a few changes:

* Add [Lucid] to the subject so Stefan knows what tree it's for (and
send multiple patches for separate trees where required, unless Stefan
has a better approach)
* Put the SRU justification in the bug report and in the patch commit message
* A justification for pre-stable and pre-upstream inclusion in the
released ubuntu kernel

Otherwise, this looks good to me. You can ack me for the upstream
submission if you want, though I don't carry much weight there yet :).

-- Chase

More information about the kernel-team mailing list