[PATCH 0/3] [UBUNTU]: [Upstream] i915 ignore ACPI lid status to determine LVDS connection

Bryce Harrington bryce at canonical.com
Mon Mar 29 17:18:05 UTC 2010


How certain are we that this won't cause secondary regressions?  I.e.,
presumably while the ACPI bios might be unreliable in general, it may
work in some cases - are we sure this won't cause those cases to fail?
If we end up needing to reverse-quirk these cases we've not bought much
(actually we lose a little, since we already understand the current
quirking situation, but reverse-quirking would be something new.)

On Mon, Mar 29, 2010 at 05:00:59PM +0300, Surbhi Palande wrote:
> There have been many quirks to ignore the lid status reported by the
> ACPI bios. Further, this list is not know to be complete yet. Due to this
> incorrect lid status reported, many laptops get a blank screen without these
> quirks. Looking at the long quirk list, upstream has reverted the code which
> takes this acpi reported lid status into consideration for i915 display. This
> means that the "no connector reported" error will no longer be seen with
> the upstream code.
> 
> The patches in this thread do the following:
> 1) revert the quirk for blacklisting an acpi bios
> 2) adds and uses a macro definition from a patch. This macro definition is
> used by the upstream patch which ignores this lid status.
> 3) cherry picks the upstream patch which ignores the lid status.
> 
> Kindly do consired merging these changes in Lucid.
> This will fix the bug 515246 on launchpad reported by multiple users.
> 
> 
> Eric Anholt (1):
>   drm/i915: Stop trying to use ACPI lid status to determine LVDS
>     connection.
> 
> Surbhi Palande (2):
>   Revert "(pre-stable) drm/i915: blacklist lid status: Sony
>     VGN-BX196VP, Dell Inspiron 700m"
>   drm/i915: Part of: Add initial bits for VGA modesetting bringup on
>     Sandybridge.
> 
>  drivers/gpu/drm/i915/i915_drv.h      |    9 ++++-
>  drivers/gpu/drm/i915/intel_display.c |    2 +-
>  drivers/gpu/drm/i915/intel_lvds.c    |   66 +---------------------------------
>  3 files changed, 10 insertions(+), 67 deletions(-)
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team




More information about the kernel-team mailing list