[PATCH] hwmon: (it87) Add support for the ITE IT8720F Bug: #357766

[Stefan Bader]

David Partington wrote:
> Tim Gardner wrote:
>> David Partington wrote:
>>  
>>> Tim Gardner wrote:
>>>    
>>>> David Partington wrote:
>>>>  
>>>>      
>>>>> Kernel team:
>>>>>
>>>>>
>>>>> I have a Biostar motherboard with the it8716 superio device.  When I
>>>>> execute the sensors hardware monitor the VID values is incorrect,  In
>>>>> reviewing the it87.c source I fine the following code burst:
>>>>>
>>>>>             
>>>> <snip>
>>>>
>>>> Well, you've gotten this far. How about a proper patch?
>>>>
>>>>         
>>> Tim,
>>>
>>> Thanks for your reply.  Actually in the code submitted at the bottom of
>>> my email was the suggested change.  However, I did submit an actual
>>> defect report with the suggested fix as well.  Please see new defect
>>> #528741.
>>>
>>> Regards, David
>>>
>>>     
>>
>> The code at the bottom of
>> https://lists.ubuntu.com/archives/kernel-team/2010-February/009082.html
>> is not a proper patch wrt the Linux kernel ecosystem. See
>> Documentation/SubmittingPatches in Linus' kernel tree at
>> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git.
>>
>> The advantage of using diff and patch is the avoidance of transcription
>> errors when applying patches.
>>
>> rtg
>>   
> Okay.
> 
> I have never submitted a kernel patch before - so you are correct, I
> probably did not follow a recommended procedure.  I thought that rather
> than complaining about something that does not work, I endeavored to
> show how to fix the issue.
> 
> Regards, David
> 

Hi David,

the issue is not so much that you did not follow a procedure, but that you can
help greatly by doing it to get the fix taken forward without needing too much
time and being prone to errors.
If you for the approach have a copy of the file as it is now and one copy of it
as it should be, then a diff -up <old file> <new file> >mypatch.patch gives you
a file which can be taken an used to make the exact same changes as you did.
Following a textual description, it is just too easy to get things wrong.

Cheers,
Stefan