[PATCH] hwmon: (it87) Add support for the ITE IT8720F Bug: #357766

Tim Gardner tim.gardner at canonical.com
Mon Mar 1 14:49:13 UTC 2010


David Partington wrote:
> Tim Gardner wrote:
>> David Partington wrote:
>>  
>>> Kernel team:
>>>
>>>
>>> I have a Biostar motherboard with the it8716 superio device.  When I
>>> execute the sensors hardware monitor the VID values is incorrect,  In
>>> reviewing the it87.c source I fine the following code burst:
>>>
>>>     
>>
>> <snip>
>>
>> Well, you've gotten this far. How about a proper patch?
>>
>>   
> Tim,
> 
> Thanks for your reply.  Actually in the code submitted at the bottom of
> my email was the suggested change.  However, I did submit an actual
> defect report with the suggested fix as well.  Please see new defect
> #528741.
> 
> Regards, David
> 

The code at the bottom of
https://lists.ubuntu.com/archives/kernel-team/2010-February/009082.html
is not a proper patch wrt the Linux kernel ecosystem. See
Documentation/SubmittingPatches in Linus' kernel tree at
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git.

The advantage of using diff and patch is the avoidance of transcription
errors when applying patches.

rtg
-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list