[Lucid SRU] UBUNTU: SAUCE: dell-laptop: fire SMI when toggling hardware killswitch

Chase Douglas chase.douglas at canonical.com
Wed Jun 9 14:11:29 UTC 2010


On Wed, 2010-06-09 at 15:08 +0200, Stefan Bader wrote:
> On 06/09/2010 12:05 PM, Keng-YĆ¼ Lin wrote:
> >   There are several sauce patches for dell-laptop.c in lucid tree. The
> > code difference between lucid tree and stable tree makes it difficult
> > to fix in a simple patch.
> 
> Ok, sorry I missed that note about the SAUCE patch in the initial request. But
> it would bring up the question to me, why the other patch has not gone upstream.
> Was it tried but rejected? If so, why?
> Is the same patch not needed for Maverick? Is the other patch in there? This
> sounds a bit like being simpler to forget things on the way forward.

I think way back in the early lucid development some patches were
applied to our tree that did not come from upstream. Matthew Garrett,
the upstream maintainer, took the patches and reworked them some.
However, the damage is done now, so we can't converge the two without a
wholesale replacement of parts of the lucid driver.

That said, we need to be sure that anything we put into Lucid is also
pushed upstream in a form that is applicable to their sources. In fact,
it may make the most sense to push changes to this driver upstream
first, and then propose a reworked version for lucid once it is
accepted.

-- Chase





More information about the kernel-team mailing list