[PATCH 2/3] UBUNTU: SAUCE: smsc95xx: fix macaddr parameter parsing

Bryan Wu bryan.wu at canonical.com
Tue Jul 13 03:22:48 UTC 2010


From: Sebastien Jan <s-jan at ti.com>

Depending on the position of the macaddr parameter in the command
line, it could be badly interpreted and discarded.

Signed-off-by: Sebastien Jan <s-jan at ti.com>
---
 drivers/net/usb/smsc95xx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 0ba06d9..8a4d92b 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -677,7 +677,7 @@ static int smsc95xx_is_macaddr_param(struct usbnet *dev, u8 *dev_mac)
 		}
 	}
 
-	if (j == MAC_ADDR_LEN && !macaddr[i]) {
+	if (j == MAC_ADDR_LEN) {
 		netif_dbg(dev, ifup, dev->net, "Overriding MAC address with: "
 		"%02x:%02x:%02x:%02x:%02x:%02x\n", mtbl[0], mtbl[1], mtbl[2],
 						mtbl[3], mtbl[4], mtbl[5]);
-- 
1.7.0.4





More information about the kernel-team mailing list