[maverick][PATCH] UBUNTU: SAUCE: Load SysLink modules on start-up on OMAP4 devices

[Dechesne, Nicolas]

>
Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 753.920

-----Original Message-----

> From: Lee Jones [mailto:lee.jones at canonical.com]
> Sent: Wednesday, July 07, 2010 2:05 PM
> To: kernel-team
> Cc: Dechesne, Nicolas
> Subject: Re: [maverick][PATCH] UBUNTU: SAUCE: Load SysLink modules on
> start-up on OMAP4 devices
>
> >> +module_init(omap4_syslink_init);
> >
> > you aren't in a module here, this code is built-in in the kernel (and
> will always be).
> > This is supposed to be called during platform init, not during
> do_initcall. Can we call
> > this function from the machine init function instead of using this trick?
> > (e.g. omap_4430sdp_init() and omap_panda_init())
>
> Okay, I've had a bit of a poke around.
>
> module_init() == device_initcall()
>
> Would device_initcall be a more appropriate naming convention for you?

if module_init is already used in many places, I am fine with this approach.

>
> All of the *_init* calls fall back to the same line of code.
>
> #define __define_initcall(level,fn,id) \
>       static initcall_t __initcall_##fn##id __used \
>       __attribute__((__section__(".initcall" level ".init"))) = fn