[PATCH] omap: Register pandaboard for uncompress traces

Tim Gardner tim.gardner at canonical.com
Tue Jul 6 12:54:34 UTC 2010


On 07/06/2010 03:49 AM, Bryan Wu wrote:
> On 07/06/2010 05:37 PM, Sebastien Jan wrote:
>> Register the pandaboard into arch_decomp_setup() to get the
>> decompressions traces.
>>
>> Signed-off-by: Sebastien Jan<s-jan at ti.com>
>
> Looks reasonable to me
> Acked-by: Bryan Wu<bryan.wu at canonical.com>
>
> But there should be a space between your name and email in S-O-B line.
>
>> ---
>>    arch/arm/plat-omap/include/plat/uncompress.h |    1 +
>>    1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/plat-omap/include/plat/uncompress.h b/arch/arm/plat-omap/include/plat/uncompress.h
>> index 81d9ec5..30411b0 100644
>> --- a/arch/arm/plat-omap/include/plat/uncompress.h
>> +++ b/arch/arm/plat-omap/include/plat/uncompress.h
>> @@ -157,6 +157,7 @@ static inline void __arch_decomp_setup(unsigned long arch_id)
>>
>>    		/* omap4 based boards using UART3 */
>>    		DEBUG_LL_OMAP4(3, omap_4430sdp);
>> +		DEBUG_LL_OMAP4(3, omap4_panda);
>>
>>    		/* zoom2/3 external uart */
>>    		DEBUG_LL_ZOOM(omap_zoom2);
>

Applied after fixing Windoze mangling. Isn't this a Linux project?

rtg at lochsa:/usr3/ubuntu/ubuntu-maverick$ scripts/checkpatch.pl 
~/tmp/omap4.eml
ERROR: DOS line endings
#73: FILE: arch/arm/plat-omap/include/plat/uncompress.h:160:
+^I^IDEBUG_LL_OMAP4(3, omap4_panda);^M$

total: 1 errors, 0 warnings, 7 lines checked

/home/rtg/tmp/omap4.eml has style problems, please review.  If any of 
these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list