[PATCH] UBUNTU: [Config] ext3 defaults to ordered mode

Tim Gardner tim.gardner at canonical.com
Thu Jan 21 14:00:12 GMT 2010


I am not in agreement. ORDERED was the implicit default _before_ Karmic
because there was no other option. However, Karmic has _not_ had ORDERED
set since the first 2.6.30 based release. Changing ORDERED at this point
 changes the fundamental behavior of the file system. I think we need to
solicit the considered opinion of our platform brethren. I have no idea
how this might affect select() or poll() or other file system
notification mechanisms.

SRU policy states that patches must fix a real problem. IMHO this does
not fix the root issue, which is the crash, _not_ the file system
corruption. No file system code will be able to withstand crashes at the
right critical point.

Steve, Martin - any thoughts on this? Am I just blowing things all out
of proportion?

rtg

P.S. I have no problem with setting ORDERED on Lucid.

Stefan Bader wrote:
> This restores our original default, prevents some cases of corruption after
> crashes and Kees wants it, too.
> 
> Surbhi Palande wrote:
>> This patch fixes bug 510067 on launchpad.
>> This patch enables the compile time option CONFIG_EXT3_DEFAULTS_TO_ORDERED
>> to ensure the data=ordered mode for an ext3 fs mount. This prevents a security 
>> threat of older data being inadvertently exposed, that arises from mounting the
>> ext3 fs with the data=writeback mode.
>>
>> Do consider merging this for Karmic.
>>
>>
>> From 6978a248df3aab38476659e164020b35f7b227ad Mon Sep 17 00:00:00 2001
>> From: Surbhi Palande <surbhi.palande at canonical.com>
>> Date: Wed, 20 Jan 2010 15:28:31 +0200
>> Subject: [PATCH] UBUNTU: [Config] ext3 defaults to ordered mode
>>
>> BugLink: http://bugs.launchpad.net/bugs/510067
>> Ignore: yes
>>
>> To prevent a security threat of older data being inadvertently exposed,
>> the default mount option of ext3 should be ordered instead of writeback. This
>> patch enables the compile time option CONFIG_EXT3_DEFAULTS_TO_ORDERED
>> to ensure the data=ordered mode for an ext3 fs mount.
>>
>> Signed-off-by: Surbhi Palande <surbhi.palande at canonical.com>
> Acked-by: Stefan Bader <stefan.bader at canonical.com>
> 
>> ---
>>  debian.master/config/config.common.ports  |    2 +-
>>  debian.master/config/config.common.ubuntu |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/debian.master/config/config.common.ports b/debian.master/config/config.common.ports
>> index 39ee289..4e22aeb 100644
>> --- a/debian.master/config/config.common.ports
>> +++ b/debian.master/config/config.common.ports
>> @@ -817,7 +817,7 @@ CONFIG_EXT2_FS_POSIX_ACL=y
>>  CONFIG_EXT2_FS_SECURITY=y
>>  CONFIG_EXT2_FS_XATTR=y
>>  # CONFIG_EXT2_FS_XIP is not set
>> -# CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set
>> +CONFIG_EXT3_DEFAULTS_TO_ORDERED=y
>>  CONFIG_EXT3_FS=y
>>  CONFIG_EXT3_FS_POSIX_ACL=y
>>  CONFIG_EXT3_FS_SECURITY=y
>> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
>> index 462c1c1..2477234 100644
>> --- a/debian.master/config/config.common.ubuntu
>> +++ b/debian.master/config/config.common.ubuntu
>> @@ -943,7 +943,7 @@ CONFIG_EXT2_FS_POSIX_ACL=y
>>  CONFIG_EXT2_FS_SECURITY=y
>>  CONFIG_EXT2_FS_XATTR=y
>>  # CONFIG_EXT2_FS_XIP is not set
>> -# CONFIG_EXT3_DEFAULTS_TO_ORDERED is not set
>> +CONFIG_EXT3_DEFAULTS_TO_ORDERED=y
>>  CONFIG_EXT3_FS=y
>>  CONFIG_EXT3_FS_POSIX_ACL=y
>>  CONFIG_EXT3_FS_SECURITY=y
> 
> 


-- 
Tim Gardner tim.gardner at canonical.com



More information about the kernel-team mailing list