[PATCH] Input: ALPS - add interleaved protocol support (Dell E6x00 series)

Dmitry Torokhov dmitry.torokhov at gmail.com
Tue Jan 19 08:36:14 UTC 2010


On Mon, Jan 18, 2010 at 03:23:12PM +0100, Stefan Bader wrote:
> I am a bit uncertain about this patch in stable from the view of regression
> avoidance. Looking over the patch its hard to tell for certain whether the path
> of execution is the same as before for the non-interleaved protocol.
> Dmitry, how do you feel about it? Or maybe there has even be positive testing
> with non-interleaved hardware with that patch.

Umm, it is a bit large for -stable to my taste. However without the
patch the affected laptops are pretty much unusable so I think we better
get it in. The non-interleaved devices should continue to work fine, at
least I don't see any adverse effects on my d630 (caveat - I am not
using _this_ version of the patch but rather what is currently in Linus's
tree).

Thanks.

> 
> -Stefan
> 
> Andy Isaacson wrote:
> > From: Sebastian Kapfer <sebastian_kapfer at gmx.net>
> > Date: Tue, 15 Dec 2009 08:39:50 -0800
> > Subject: [PATCH] Input: ALPS - add interleaved protocol support (Dell E6x00 series)
> > 
> > commit 1d9f26262aef6d63ff65eba0fd5f1583f342b69b upstream
> > 
> > Properly handle version of the protocol where standard PS/2 packets
> > from trackpoint are stuffed into middle (byte 3-6) of the standard
> > ALPS packets when both the touchpad and trackpoint are used together.
> > 
> > The patch is based on work done by Matthew Chapman and additional
> > research done by David Kubicek and Erik Osterholm:
> > 
> > 	https://bugs.launchpad.net/ubuntu/+source/linux/+bug/296610
> > 
> > Many thanks to David Kubicek for his efforts in researching fine points
> > of this new version of the protocol, especially interaction between pad
> > and stick in these models.
> > 
> > Signed-off-by: Sebastian Kapfer <sebastian_kapfer at gmx.net>
> > Signed-off-by: Dmitry Torokhov <dtor at mail.ru>
> > ---
> > 
> > Cherrypick to 2.6.31 by Andy Isaacson <adi at hexapodia.org>.  Tested on
> > Dell E4300.
> > 
> >  drivers/input/mouse/alps.c |  252 +++++++++++++++++++++++++++++++++++++++-----
> >  drivers/input/mouse/alps.h |    1 +
> >  2 files changed, 228 insertions(+), 25 deletions(-)
> > 
> 

-- 
Dmitry




More information about the kernel-team mailing list