[LUCID 2/2] [Config] Added CONFIG_SR_REPORT_TIME_LIMIT

Amit Kucheria amit.kucheria at canonical.com
Fri Feb 12 19:45:11 UTC 2010


On 10 Feb 12, Manoy Iyer wrote:
> 
> What is the correct method of adding config options to
> config/config.common.ubuntu? create a Kconfig in drivers/ and run
> updateconfig ?
> 

Add a CONFIG_FOO entry to kernel/power/Kconfig and make it enabled
with a default value.

Look at how BLK_DEV_RAM_COUNT is done in drivers/block/Kconfig

/Amit

> 
> On Fri, 12 Feb 2010, Amit Kucheria wrote:
> 
> >On 10 Feb 11, Manoy Iyer wrote:
> >>
> >>Config changes to set [Config] Added CONFIG_SR_REPORT_TIME_LIMIT=NNN where
> >>it will print suspend/resume report of any driver/device that takes more
> >>than NNN msec to resume.
> >>
> >>The following changes since commit
> >>a913ef9ba3b23aee8db094d5ab5804777c697ef1:
> >>   Andy Whitcroft (1):
> >>         UBUNTU: Ubuntu-2.6.32-13.18
> >>
> >>are available in the git repository at:
> >>
> >>
> >>ssh://zinc.canonical.com/srv/kernel.ubuntu.com/git/manjo/ubuntu-lucid.git
> >>srtime
> >>
> >>Manoj Iyer (2):
> >>       UBUNTU: SAUCE: PM report driver and device suspend/resume times.
> >>       UBUNTU: [Config] Added CONFIG_SR_REPORT_TIME_LIMIT
> >>
> >>  debian.master/config/config.common.ubuntu |    1 +
> >>  drivers/base/power/main.c                 |   35
> >>+++++++++++++++++++++++++++++
> >>  2 files changed, 36 insertions(+), 0 deletions(-)
> >>
> >>From 795589e57107f73015bc64a9f880b824c79df1fd Mon Sep 17 00:00:00 2001
> >>From: Manoj Iyer <manoj.iyer at canonical.com>
> >>Date: Thu, 11 Feb 2010 13:38:08 -0600
> >>Subject: [PATCH] UBUNTU: [Config] Added CONFIG_SR_REPORT_TIME_LIMIT
> >>
> >>To print driver/device suspend/resume time greater than NNN msec
> >>use CONFIG_SR_REPORT_TIME_LIMIT=NNN
> >>
> >>Signed-off-by: Manoj Iyer <manoj.iyer at canonical.com>
> >>---
> >>  debian.master/config/config.common.ubuntu |    1 +
> >>  1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >>diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> >>index 94e6614..017b821 100644
> >>--- a/debian.master/config/config.common.ubuntu
> >>+++ b/debian.master/config/config.common.ubuntu
> >>@@ -3711,6 +3711,7 @@ CONFIG_SPLIT_PTLOCK_CPUS=4
> >>  CONFIG_SQUASHFS=m
> >>  # CONFIG_SQUASHFS_EMBEDDED is not set
> >>  CONFIG_SQUASHFS_FRAGMENT_CACHE_SIZE=3
> >>+# CONFIG_SR_REPORT_TIME_LIMIT is not set
> >>  CONFIG_SSB=m
> >>  # CONFIG_SSB_DEBUG is not set
> >>  CONFIG_SSB_DRIVER_PCICORE=y
> >>--
> >
> >Did you run updateconfigs after you mushed-in CONFIG_SR_REPORT_TIME_LIMIT
> >into config.common.ubuntu?
> >
> >There should be a Kconfig option for this that I don't see in either this
> >patch or the previous one.
> >
> >NACK.
> >
> >/Amit
> >
> >-- 
> >----------------------------------------------------------------------
> >Amit Kucheria, Kernel Engineer || amit.kucheria at canonical.com
> >----------------------------------------------------------------------
> >
> >-- 
> >kernel-team mailing list
> >kernel-team at lists.ubuntu.com
> >https://lists.ubuntu.com/mailman/listinfo/kernel-team
> >

-- 
----------------------------------------------------------------------
Amit Kucheria, Kernel Engineer || amit.kucheria at canonical.com
----------------------------------------------------------------------




More information about the kernel-team mailing list