[PATCH] UBUNTU: AUFS -- Fix header files inclusion in debug.h

Tim Gardner tim.gardner at canonical.com
Tue Feb 9 21:13:39 UTC 2010


Mirsal Ennaime wrote:
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/517151
> 
> The aufs module fails to build with CONFIG_AUFS_DEBUG=y
> The issue is not present in lucid because the whole driver code was synced
> with the upstream aufs tree.
> 
> As I discussed with Andy Whitcroft on IRC, I'm not sure it justifies an SRU,
> as it is unlikely that anyone would really want to build aufs with debugging
> support from the karmic kernel sources package.
> 
> Signed-off-by: Mirsal Ennaime <mirsal.ennaime at gmail.com>
> ---
>  ubuntu/aufs/debug.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/ubuntu/aufs/debug.h b/ubuntu/aufs/debug.h
> index dab15f7..d22aff8 100644
> --- a/ubuntu/aufs/debug.h
> +++ b/ubuntu/aufs/debug.h
> @@ -25,9 +25,10 @@
> 
>  #ifdef __KERNEL__
> 
> +#include <asm/system.h>
>  #include <linux/bug.h>
>  /* #include <linux/err.h> */
> -/* #include <linux/init.h> */
> +#include <linux/init.h>
>  /* #include <linux/kernel.h> */
>  #include <linux/delay.h>
>  /* #include <linux/kd.h> */

I can think of at least one case recently where building with debug
would have been handy (though it was for Hardy).

Seems that there is little chance of regression with an additional
header file. It'll either build, or it won't. Check for new warnings.

Acked-by: Tim Gardner <tim.gardner at canonical.com>

-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list