[PATCH] UBUNTU: (pre-stable): input: Support Clickpad devices in ClickZone mode

Tim Gardner tim.gardner at canonical.com
Wed Dec 15 14:06:14 UTC 2010


On 12/15/2010 03:44 AM, Henrik Rydberg wrote:
> On 12/14/2010 11:06 PM, Robert Hooker wrote:
>
>> From: Takashi Iwai<tiwai at suse.de>
>>
>> Add the experimental support of new Synatpics "Clickpad" devices.
>>
>> This device reports the click as the middle-button, but it doesn't set
>> proper capability bits.  Thus the driver needs to check the product-id
>> and forces to enable the button detection.
>>
>> In this patch, the device behaves as "ClickZone" mode, and gives
>> compatible events as other normal synaptics devices so that user-space
>> app works as is.  In the ClickZone mode, the buttons are emulated as
>> clicks in the bottom button zone.  Left and right clicks are judged by
>> the touch position.  Clicking the narrow middle point in the button
>> zone gives a middle click.
>>
>> Dragging can be done by keeping the button down and touching the normal
>> area again.  Strangely, the sequence to click after touching the area
>> doesn't work with this device by unknown reason...
>>
>> Signed-off-by: Takashi Iwai<tiwai at suse.de>
>>
>> BugLink: http://bugs.launchpad.net/bugs/516329
>>
>> Acked-by: Colin King<colin.king at canonical.com>
>> Acked-by: Andy Whitcroft<apw at canonical.com>
>> Signed-off-by: Chase Douglas<chase.douglas at canonical.com>
>> Signed-off-by: Andy Whitcroft<apw at canonical.com>
>>
>> Fixed clickpad capability checks to only check the 0x0c cap.
>>
>> Signed-off-by: Robert Hooker<robert.hooker at canonical.com>
>> ---
>
>
> Just a heads-up that this will conflict again as we move to 2.6.38.
>

No worries on that score since Maverick won't get pulled forward anyways.

As suggested, I like the revert, then the patch from Takashi Iwai (which 
should be marked as SAUCE). Its pretty close to what is coded in Linus' 
repo. (see 5f57d67da87332a9a1ba8fa7a33bf0680e1c76e7)

Acked-by: Tim Gardner <tim.gardner at canonical.com>

-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list