[Maverick] [PATCH] UBUNTU - ARM: Reverting patch that break mmc init
mathieu.poirier at canonical.com
Tue Aug 10 14:28:03 UTC 2010
On Mon, 2010-08-09 at 16:00 -0700, Tim Gardner wrote:
> On 08/09/2010 09:58 AM, Mathieu Poirier wrote:
> > Ensure regulator enable
> What does TI think about this? Its not been reverted upstream. Is there
> a better way to implement the functionality in the original patch?
The patch hasn't been reverted upstream because no one upstream is
seeing this issue. Only Ubuntu compiles with all 4 flags enabled. I
tried to discuss my findings on #beagle but only received rude comments
like "ubuntu and their crazy ways".
I thought about leaving the patch intact and reverting only the
initialization of "host->power_mode" but decided against it for
consistency reason. Fixing only the second part of the patch was my
I am well aware that reverting the patch is not the real solution. On
the other hand there is no denying the feature is broken and probably
would not have been accepted upstream had anyone been running their
system with the flags enabled.
I submitted the patch to allow the mobile team to move forward. The
system doesn't boot if the mmc card doesn't get initialized properly,
something that blocks them in all their omap3 endeavours.
All that being said, I can submit another patch that will only address
the "power_mode" initialization and leave the pairing of regulator
enables/disables intact. I will also get in touch with the implementer
of the patch and expose the problem to him.
Question/comments are welcomed.
More information about the kernel-team