[PATCH 11/16] writeback: add missing requeue_io in writeback_inodes_wb

Stefan Bader stefan.bader at canonical.com
Tue Aug 10 09:28:59 UTC 2010


From: Christoph Hellwig <hch at lst.de>

BugLink: http://bugs.launchpad.net/bugs/585092

commit 334132ae921a14ac2b2ba48e174136f7f2c9aae1 upstream

In "writeback: fix writeback_inodes_wb from writeback_inodes_sb" I
accidentally removed the requeue_io if we need to skip a superblock
because we can't pin it.  Add it back, otherwise we're getting spurious
lockups after multiple xfstests runs.

Signed-off-by: Christoph Hellwig <hch at lst.de>
Signed-off-by: Jens Axboe <jaxboe at fusionio.com>
Signed-off-by: Stefan Bader <stefan.bader at canonical.com>
---
 fs/fs-writeback.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 02b62a4..58a8de2 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -631,8 +631,10 @@ static void writeback_inodes_wb(struct bdi_writeback *wb,
 
 			ret = writeback_sb_inodes(sb, wb, wbc);
 		} else {
-			if (!pin_sb_for_writeback(sb))
+			if (!pin_sb_for_writeback(sb)) {
+				requeue_io(inode);
 				continue;
+			}
 			ret = writeback_sb_inodes(sb, wb, wbc);
 			drop_super(sb);
 		}
-- 
1.7.0.4





More information about the kernel-team mailing list