Please cherry-pick audio patch for Dell Optiplex

Leann Ogasawara leann.ogasawara at
Tue Aug 3 15:34:11 UTC 2010

On Tue, 2010-08-03 at 09:50 +0200, David Henningsson wrote:
> I would like us to cherry-pick commit b08b1637ce from
>, put it into
> Maverick, test it there for a month or two and assuming no regressions,
> I'll submit it to stable at and it'll reach Lucid that way. It's
> in Takashi's tree, so it will be in 2.6.36.
> If applied, it will fix playback on several Dell Optiplex machines and
> some others. There is a theoretical risc for regressions for people
> having ALC268 chips with broken BIOSes, but I believe it is very small,
> but still that's why I would like some testing in Maverick first.
> (If the patch does not apply cleanly, apply 5d4abf93 first.)

Hi David,

Is there a bug in Launchpad open to track this issue?  ie. is there
confirmation that this indeed resolves the issue?  Care to also add your
SOB (signed-off-by) to this for Maverick?  Also, I'm just inlining the
patch in question below for ease of review:

>From b08b1637ce1c0196970348bcabf40f04b6b3d58e Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai at>
Date: Fri, 30 Jul 2010 14:08:25 +0200
Subject: [PATCH] ALSA: hda - Handle pin NID 0x1a on ALC259/269

The pin NID 0x1a should be handled as well as NID 0x1b.
Also added comments.

Signed-off-by: Takashi Iwai <tiwai at>
 sound/pci/hda/patch_realtek.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 4d3a6f0..ce6c3a9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -13158,7 +13158,8 @@ static int alc268_new_analog_output(struct alc_spec *spec, hda_nid_t nid,
 		dac = 0x02;
 	case 0x15:
-	case 0x1b:
+	case 0x1a: /* ALC259/269 only */
+	case 0x1b: /* ALC259/269 only */
 	case 0x21: /* ALC269vb has this pin, too */
 		dac = 0x03;

More information about the kernel-team mailing list