[PATCH 5/5] UBUNTU: SAUCE: IMX51: fix stgl5000 regulator_get failing error

Bryan Wu bryan.wu at canonical.com
Thu Apr 29 01:29:34 UTC 2010


On 04/29/2010 12:17 AM, Colin Ian King wrote:
> On Fri, 2010-04-23 at 10:29 +0800, Bryan Wu wrote:
>> BugLink: http://bugs.launchpad.net/bugs/567157
>>
>> In Freescale BSP, commit 2d75a8fa9d7c7272b3b81268c2fb33a57be9a072 removes
>> regulator_consumer_supply VDDD which will be used by stgl5000 driver. So it
>> will give us an error message during booting:
>>
>> 'regulator: Unable to get requested regulator: VDDD'
>>
>> This patch added it back and fix this error.
>>
>> Signed-off-by: Bryan Wu<bryan.wu at canonical.com>
>> ---
>>   arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c |    5 +++++
>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c b/arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c
>> index 72d8baf..e8a03cf 100644
>> --- a/arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c
>> +++ b/arch/arm/mach-mx51/mx51_babbage_pmic_mc13892.c
>> @@ -99,6 +99,11 @@ static struct regulator_consumer_supply vdig_consumers[] = {
>>   		.supply = "VDDA",
>>   		.dev_name = "1-000a",
>>   	}
>> +	{
>> +		/* sgtl5000 */
>> +		.supply = "VDDD",
>> +		.dev_name = "1-000a",
>> +	},
>>   };
>>
>>   static struct regulator_consumer_supply vvideo_consumers[] = {
>> --
>> 1.7.0.1
>>
>>
> Urm, I'm confused about this patch - isn't the VDDD already enabled in
> the current lucid fsl-imx51 branch?
>
>

VDDD's already been enabled in our Lucid fsl-imx51 branch. But it was removed in 
Freescale's patch which is "[PATCH 3/5] ENGR00121069: MX51: Complete the 
constraints for the various regulators.". I don't wanna to change their patch, 
so I fixed here. I will post my fix to Freescale later.

IMHO, this is an obvious mistake in their BSP.

Thanks,
-- 
Bryan Wu <bryan.wu at canonical.com>
Kernel Developer    +86.138-1617-6545 Mobile
Ubuntu Kernel Team | Hardware Enablement Team
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com




More information about the kernel-team mailing list