[PATCH] dell-laptop: defer dell_rfkill_update to worker thread

Matthew Garrett mjg59 at srcf.ucam.org
Tue Apr 13 14:58:10 UTC 2010


On Tue, Apr 13, 2010 at 03:29:00PM +0100, Andy Whitcroft wrote:

> Looks like a fair work-around.  In theory we could loose key-press
> effects here which would could lead us to be out of sync with the H/W,
> though to do that one would have to hit the key before the handler could
> complete -- which I suspect is close to impossible to achieve.  In that
> case we get a clear diagnostic, and its a heck of a lot better than a
> Panic.

I think this case is fine. The button press updates the hardware, and 
when the update task eventually gets run it'll read the state from the 
hardware, so it doesn't matter how many toggles happen in the 
intervening time.

-- 
Matthew Garrett | mjg59 at srcf.ucam.org




More information about the kernel-team mailing list