[PATCH 0/5] UBUNTU: [Upstream] Enable Marvell 88E8059 Support

Chase Douglas chase.douglas at canonical.com
Mon Apr 12 13:33:08 UTC 2010

On Sun, Apr 11, 2010 at 11:32 PM, Eric Miao <eric.miao at canonical.com> wrote:
> Bug is reported at: http://bugs.launchpad.net/bugs/537168.
> The patchset includes 5 small patches. A test kernel is built and reported
> to work.
> UBUNTU: [Upstream] sky2: print Optima chip name
> UBUNTU: [Upstream] net: Add missing TST_CFG_WRITE bits around sky2_pci_write
> UBUNTU: [Upstream] net: Fix Yukon-2 Optima TCP offload setup
> UBUNTU: [Upstream] sky2: add register definitions for new chips
> UBUNTU: [Upstream] sky2: 88E8059 support
> And a git pull is available at:
>  git://kernel.ubuntu.com/ycmiao/ubuntu-lucid.git lp537168
> Please help review.

I would prefer the first and second patches to be swapped in order. If
someone goes to git bisect and they fall in between the two the driver
won't build because the first patch uses macros defined in the second.
However, if this is the order from upstream, then it's probably best
to keep it that way.

-- Chase

More information about the kernel-team mailing list