[PATCH 3/6] UBUNTU: SAUCE: ipw2200: Enable LED by default

Tim Gardner tim.gardner at canonical.com
Wed Sep 16 17:45:57 UTC 2009


Andy Whitcroft wrote:
> From: ubuntu at tjworld.net <ubuntu at tjworld.net>
> 
> BugLink: http://bugs.launchpad.net/bugs/21367
> 
> Enable LED by default. Original (vague) reason for defaulting to disabled
> documented in 2005 no longer appears applicable, and users have been
> requesting this for several years.
> 
> Change the MODULE_PARM_DESC for led
> 
> Signed-off-by: TJ <ubuntu at tjworld.net>
> Signed-off-by: Tim Gardner <tim.gardner at canonical.com>
> Signed-off-by: Andy Whitcroft <apw at canonical.com>
> ---
>  Documentation/networking/README.ipw2200 |    2 +-
>  drivers/net/wireless/ipw2x00/ipw2200.c  |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/networking/README.ipw2200 b/Documentation/networking/README.ipw2200
> index 80c7285..e4d3267 100644
> --- a/Documentation/networking/README.ipw2200
> +++ b/Documentation/networking/README.ipw2200
> @@ -171,7 +171,7 @@ Where the supported parameter are:
>    
>    led
>  	Can be used to turn on experimental LED code.
> -	0 = Off, 1 = On.  Default is 0.
> +	0 = Off, 1 = On.  Default is 1.
>  
>    mode
>  	Can be used to set the default mode of the adapter.  
> diff --git a/drivers/net/wireless/ipw2x00/ipw2200.c b/drivers/net/wireless/ipw2x00/ipw2200.c
> index f593fbb..7babf61 100644
> --- a/drivers/net/wireless/ipw2x00/ipw2200.c
> +++ b/drivers/net/wireless/ipw2x00/ipw2200.c
> @@ -89,7 +89,7 @@ static int mode = 0;
>  static u32 ipw_debug_level;
>  static int associate;
>  static int auto_create = 1;
> -static int led = 0;
> +static int led = 1;
>  static int disable = 0;
>  static int bt_coexist = 0;
>  static int hwcrypto = 0;
> @@ -11964,7 +11964,7 @@ module_param(auto_create, int, 0444);
>  MODULE_PARM_DESC(auto_create, "auto create adhoc network (default on)");
>  
>  module_param(led, int, 0444);
> -MODULE_PARM_DESC(led, "enable led control on some systems (default 0 off)");
> +MODULE_PARM_DESC(led, "enable led control on some systems (default 1 on)");
>  
>  module_param(debug, int, 0444);
>  MODULE_PARM_DESC(debug, "debug output mask");

ACK

-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list