[PATCH 0/3] Updating lenovo-sl-laptop driver

Tim Gardner tim.gardner at canonical.com
Wed Sep 9 13:44:05 UTC 2009


Ike Panhc wrote:
> Tim Gardner wrote:
>> https://lists.ubuntu.com/archives/kernel-team/2009-August/007018.html
>>
>> I've pushed the updates to the Lenovo SL lapto driver sans the ACPI
>> hotkey patch as I've yet to see any substantive discussion between you
>> and the upstream developer. What is going on there? Are you getting any
>> response?
>>
>> Frankly, I prefer your non-polled approach to monitoring ACPI hotkey
>> events, but I'd still like to understand Alexandre's objections.
>>
>> rtg
> 
> The last mail he replied said he does not agree that I remove the backlight
> brightness adjusting in driver. I added those code back and told him that
> I prefer to rely on user application to adjust backlight brightness. After
> the mail it is no response from now. It is almost one month ago, I will ask
> again.
> 
> With your reminding. I check the whole driver with checkpatch.pl and have 9
> Error and 6 warning - after I fix some. I am planing to fix them all and
> modify some dangerous part of the driver, and sent to linux-acpi for another
> review. How do you think about this?
> 
> -- Ike Panhc

Sounds good.
-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list