[PATCH] UBUNTU: [Hardy SRU] LP#310760 Fix the MIC of the Lenovo webcam problem

AceLan Kao acelan.kao at canonical.com
Tue Sep 1 13:35:08 UTC 2009

Dear Stefan,

Yes,it's ok.
In the normal situation the turn on led command should be placed at
this block after the switch case statement
   if (GammaT && MatrixT){
   case SENSOR_MI1310_SOC:
doesn't assign GammaT and MatrixT for this chip, so we'll never run
into that block, so that I placed the turn on led command in the case
The same situation happened at Jaunty kernel(2.6.28). And the latest
kernel has assigned those two variables, so the turn on command is
placed in the if statement block.

The original code block doesn't sensible enough, those two variables
do nothing with led, but led command is placed in that block. So I
think this way to patch Hardy is fine and more sensible than upstream.

Best regards,
AceLan Kao.

2009/9/1 Stefan Bader <stefan.bader at canonical.com>:
> Just to be on the safe side, I see the code to turn off the LED
> differentiates between the one SOC and others. But to turn the LED on, there
> is only one common statement added. AceLan, is this ok?

Chia-Lin Kao(AceLan)
E-Mail: acelan.kaoATcanonical.com (s/AT/@/)

More information about the kernel-team mailing list