[PATCH 1/5] Fix mute key for T series Thinkpads

Amit Kucheria amit.kucheria at canonical.com
Tue Sep 1 08:24:08 UTC 2009


On 09 Aug 29, Jerone Young wrote:
> commit 68329ca7fdb5d388c772189e1c18e6e428fb9d2d
> Author: Jerone Young <jerone.young at canonical.com>
> Date:   Thu Aug 27 00:04:44 2009 -0500
> 
>     ACPI: Add Thinkpad T400 & Thinkpad T500 to OSI(Linux) white-list
>     
>     acpi_osi=Linux helps the mute button work properly by sending Linux
>     a mute key press. This is the same behavior as seen with the Thinkpad
>     T61 already on the white list.
>  
>     Signed-off-by: Jerone Young <jerone.young at canonical.com>
> 
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> index f6baa77..c201ac0 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -251,6 +251,22 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
>  		     DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X61"),
>  		},
>  	},
> +	{
> +	.callback = dmi_enable_osi_linux,
> +	.ident = "Lenovo ThinkPad T400",
> +	.matches = {
> +		     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +		     DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T400"),
> +		},
> +	},
> +	{
> +	.callback = dmi_enable_osi_linux,
> +	.ident = "Lenovo ThinkPad T500",
> +	.matches = {
> +		     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +		     DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T500"),
> +		},
> +	},
>  	{}
>  };
>  

Hi Jerone,

You could collapse all 5 patches into a single one, couldn't you? I see the
same problem being solved in each patch for different models.

Now the main question, does using acpi_osi=Linux make anything fail on these
laptops? A bug report would be handy with reports of everything being alright
after passing apci_osi=Linux on these models.

Regards,
Amit

-- 
----------------------------------------------------------------------
Amit Kucheria, Kernel Engineer || amit.kucheria at canonical.com
----------------------------------------------------------------------




More information about the kernel-team mailing list