[Karmic] SRU: Re-review of dangling Karmic patches

Andy Whitcroft apw at canonical.com
Thu Oct 29 10:19:43 UTC 2009


On Wed, Oct 28, 2009 at 10:36:17PM +0000, Stefan Bader wrote:
> There are currently 3 Karmic patches (beside of others yet to come) which have
> been applied to the tree in the gray time in between Karmic final and pre-SRU.
> So I re-send those, so we can get a more formal review of those.
> 
> 1. SRU Justification:
> 
> Impact: The default of the synaptics driver would take a too high repeat
> rate and cause problems on the Toshiba Protege M300.
> 
> Fix: Add a quirk which checks for this model and does the right thing.

Looks reasonable.  This is a model specific quirk with near zero
regression possibility.  This is upstream (not stable).

Acked-by: Andy Whitcroft <apw at canonical.com>

> 2. SRU justification:
> 
> Impact: Some USB devices claim to support long sense data but when sense
> is requested, they will fail to do so. But they work when only short sense
> is requested.
> 
> Fix: Try long format first but if that fails fall back to short sense data.
> This patch is accepted in upstream stable.

This introduces a retry on fail which fixes a number of devices.
Although the retry is generally applied it does look pretty safe.

Acked-by: Andy Whitcroft <apw at canonical.com>

> 
> 3. SRU justification:
> 
> Impact: The nx protection patch incorrectly would tell users that it is enabled
> even on hardware that does not support it.
> 
> Fix: Adding a case for unsupported hw and print a warning when this is encountered.
> 

This is only a reporting change no functionally is changed by this fix.
Looks safe.

Acked-by: Andy Whitcroft <apw at canonical.com>

-apw




More information about the kernel-team mailing list