[PATCH] Staging: Android logger: fix compiling error
Andy Whitcroft
apw at canonical.com
Mon Oct 26 13:09:16 UTC 2009
On Sat, Oct 24, 2009 at 12:52:21AM +0800, Bryan Wu wrote:
> When compiling Android staging driver for PXA3XX machine, met following error:
>
> CC drivers/staging/android/logger.o
> drivers/staging/android/logger.c: In function 'logger_read':
> drivers/staging/android/logger.c:165: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
> drivers/staging/android/logger.c:165: error: (Each undeclared identifier is reported only once
> drivers/staging/android/logger.c:165: error: for each function it appears in.)
> drivers/staging/android/logger.c:178: error: implicit declaration of function 'signal_pending'
> drivers/staging/android/logger.c:183: error: implicit declaration of function 'schedule'
> drivers/staging/android/logger.c: In function 'logger_aio_write':
> drivers/staging/android/logger.c:325: error: dereferencing pointer to incomplete type
> drivers/staging/android/logger.c:333: error: dereferencing pointer to incomplete type
> drivers/staging/android/logger.c:334: error: dereferencing pointer to incomplete type
> drivers/staging/android/logger.c:337: error: dereferencing pointer to incomplete type
> drivers/staging/android/logger.c:360: error: dereferencing pointer to incomplete type
> drivers/staging/android/logger.c:363: error: dereferencing pointer to incomplete type
> drivers/staging/android/logger.c:370: error: increment of pointer to unknown structure
> drivers/staging/android/logger.c:370: error: arithmetic on pointer to an incomplete type
> drivers/staging/android/logger.c:377: error: 'TASK_INTERRUPTIBLE' undeclared (first use in this function)
> make[3]: *** [drivers/staging/android/logger.o] Error 1
>
> Compiling broke since commit a99bbaf5ee6bad1aca0c88ea65ec6e5373e86184
> headers: remove sched.h from poll.h
>
> Adding <linux/sched.h> to fix this compiling bug.
>
> Cc: Alexey Dobriyan <adobriyan at gmail.com>
> Signed-off-by: Bryan Wu <bryan.wu at canonical.com>
> ---
> drivers/staging/android/logger.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
> index 6c10b45..a8eb7d1 100644
> --- a/drivers/staging/android/logger.c
> +++ b/drivers/staging/android/logger.c
> @@ -21,6 +21,7 @@
> #include <linux/fs.h>
> #include <linux/miscdevice.h>
> #include <linux/uaccess.h>
> +#include <linux/sched.h>
> #include <linux/poll.h>
> #include <linux/time.h>
> #include "logger.h"
This appears to be a patch for 2.6.32 kernels. It fixes compilation of
the core android functionality.
Seems appropriate for Lucid to allow testing there.
-apw
More information about the kernel-team
mailing list