Lucid Patch Review

[Colin Ian King]

On Wed, 2009-11-25 at 17:49 +0000, Andy Whitcroft wrote:
> Below is our review of the patches we are carrying in Lucid as of
> 2.6.32-4.5.  They are split into some logical sections, those we are
> clearly keeping, those which clearly should be dropped, and those which
> require further study.  For the latter we are looking to those who remember
> the patches to chime in as appropriate.  If you have comments please do
> so on this thread.  We will likely start the process of dropping patches
> shortly.

> The remainder need more review, for each I point out the original
> submitter in the hope they can help us understand whether these patches
> are still needed:
> 
>     0045-UBUNTU-SAUCE-fix-kernel-oops-in-VirtualBox-during-pa.patch
> 	Colin Ian King <colin.king at canonical.com>
> 	Its not clear that this additional locking is still needed.
> 	Need to test without this patch.

	I'd drop this for Lucid. I've tested Lucid kernel 2.6.32-5 inside of
VirtualBox 3.0.08_OSE r53138 without the patch and it works fine.
> 
>     0046-Revert-Bluetooth-Eliminate-checks-for-impossible-con.patch
> 	Colin Ian King <colin.king at canonical.com>
> 	This looks safe enough but do we really need it any more?

	It appears commit ac019360fe311dd6aa11b358a02eb3a61675882e upstream has
addressed this in *exactly* the same way. 

Colin
> -apw
>