[PATCH 5/5] UBUNTU: SAUCE: AppArmor: Fix oops there is no tracer and doing unsafe transition.

John Johansen john.johansen at canonical.com
Thu Nov 12 16:27:38 UTC 2009

Andy Whitcroft wrote:
> On Thu, Nov 12, 2009 at 11:28:10AM +0000, Andy Whitcroft wrote:
>> Hrm, now perhaps this is fixing the concern I raised in the previous
>> patch.  Perhaps it would be safer to simply make the put_cred()
>> incantation instead?
>>   if (cred)
>>     put_cred(cred);
> I guess I _am_ happy that the current form would address the concern and
> so in that sense:
> Acked-by: Andy Whitcroft <apw at canonical.com>
> I would suggest considering a more bullet proof approach as above for
> your mainline efforts as its clearer that cred can only be released if
> non-null, and its safer against further change in the function.
Yep, what you suggest would be better.

More information about the kernel-team mailing list