[Jaunty] SRU: UBUNTU: SAUCE: Added quirk to fix kernel oops during saa7134 Binitialization

[Amit Kucheria]

On Tue, May 05, 2009 at 10:23:55AM -0500, Manoj Iyer wrote:
> 
> SRU JUSTIFICATION:
> 
> IMPACT: Kernel oops during boot, saa7134 is initialized for AverMedia 
> card.
> FIX: in saa7134_tuner_setup function fix the memset size to sizeof 
> xc2028_cfg, fix mentioned on gentoo wiki, 
> http://en.gentoo-wiki.com/wiki/AverMedia_AverTV_Cardbus_Hybrid_E506R
> TEST: A test kernel in http://people.ubuntu.com/~manjo/lp316405-jaunty/ 
> was tested by the user and confirmed to fix the problem.
> 
> 
> The following changes since commit 
> f5b49085f2b571268c7c2261aabe68b43c75b8ef:
>    Brad Figg (1):
>          UBUNTU: SAUCE: Add information to recognize Toshiba Satellite Pro 
> M10 Alps Touchpad
> 
> are available in the git repository at:
> 
>    git://kernel.ubuntu.com/manjo/ubuntu-jaunty.git lp316405
> 
> Manoj Iyer (1):
>        UBUNTU: SAUCE: Added quirk to fix kernel oops during saa7134 
> initialization
> 
>   drivers/media/video/saa7134/saa7134-cards.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
> 
> From 11c024b7f42ed0c1a035b6050e8e0798a9dd1573 Mon Sep 17 00:00:00 2001
> From: Manoj Iyer <manoj.iyer at canonical.com>
> Date: Tue, 5 May 2009 10:04:16 -0500
> Subject: [PATCH] UBUNTU: SAUCE: Added quirk to fix kernel oops during saa7134 initialization
> 
> OriginalLocation: http://en.gentoo-wiki.com/wiki/AverMedia_AverTV_Cardbus_Hybrid_E506R
> 
> Bug: #316405
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/316405
> 
> Signed-off-by: Manoj Iyer <manoj.iyer at canonical.com>
> ---
>   drivers/media/video/saa7134/saa7134-cards.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/saa7134/saa7134-cards.c b/drivers/media/video/saa7134/saa7134-cards.c
> index ddc5402..8635228 100644
> --- a/drivers/media/video/saa7134/saa7134-cards.c
> +++ b/drivers/media/video/saa7134/saa7134-cards.c
> @@ -6048,7 +6048,7 @@ static void saa7134_tuner_setup(struct saa7134_dev *dev)
>   		struct v4l2_priv_tun_config  xc2028_cfg;
>   		struct xc2028_ctrl           ctl;
> 
> -		memset(&xc2028_cfg, 0, sizeof(ctl));
> +		memset(&xc2028_cfg, 0, sizeof(xc2028_cfg));
>   		memset(&ctl, 0, sizeof(ctl));
> 
>   		ctl.fname   = XC2028_DEFAULT_FIRMWARE;
> -- 
> 1.6.0.4

Looks good. ACK.

-- 
----------------------------------------------------------------------
Amit Kucheria, Kernel Engineer || amit at canonical.com
----------------------------------------------------------------------