[PATCH 1/1] UBUNTU: Copy header files for various kernel media driver

[Tim Gardner]

Andy Whitcroft wrote:
> On Wed, Mar 25, 2009 at 04:40:18PM +0800, Ike Panhc wrote:
>> Bug: #322732
>>
>> Copy header files because various kernel media driver need them.
>> Header files under drivers/media/dvb/frontends/, drivers/media/video/ and
>> drivers/media/dvb/dvb-core/ copied.
>>
>> Signed-off-by: Ike Panhc <ike.pan at canonical.com>
>> ---
>>  debian/rules.d/3-binary-indep.mk |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/debian/rules.d/3-binary-indep.mk b/debian/rules.d/3-binary-indep.mk
>> index a68b791..1ddafe3 100644
>> --- a/debian/rules.d/3-binary-indep.mk
>> +++ b/debian/rules.d/3-binary-indep.mk
>> @@ -35,6 +35,9 @@ install-headers:
>>  	  \( -name 'Makefile*' -o -name 'Kconfig*' -o -name 'Kbuild*' -o \
>>  	     -name '*.sh' -o -name '*.pl' -o -name '*.lds' \) \
>>  	  -print | cpio -pd --preserve-modification-time $(indep_hdrdir)
>> +	cp -a drivers/media/dvb/dvb-core/*.h $(indep_hdrdir)/drivers/media/dvb/dvb-core
>> +	cp -a drivers/media/video/*.h $(indep_hdrdir)/drivers/media/video
>> +	cp -a drivers/media/dvb/frontends/*.h $(indep_hdrdir)/drivers/media/dvb/frontends
>>  	cp -a scripts include $(indep_hdrdir)
>>  
>>  srcpkg = linux-source-$(release)
> 
> ACK
> 
> I did have a look at the ramifications of including all .h files in the
> headers packages.  Basically it added about 60MB to the image, ie near to
> doubling it.  If that isn't a mental ammount we might consider including
> all of them.
> 
> Thoughts?
> 
> -apw
> 

I'm not particularly keen on the idea of adding a zillion unnecessary
header files to the package. Nearly all of the .h files that are _not_
under include tend to be for internal private use by their specific
device drivers, media header files notwithstanding (but that's a
different issue).

Anyway, I'm still waiting for the pull request from Ike.

rtg
-- 
Tim Gardner tim.gardner at canonical.com