[PATCH 1/1] UBUNTU: Add 3 missing files to prerm remove file list

Bryan Wu bryan.wu at canonical.com
Wed Mar 25 13:48:55 UTC 2009


Andy Whitcroft wrote:
> On Wed, Mar 25, 2009 at 09:19:44PM +0800, bryan.wu at canonical.com wrote:
>> From: Bryan Wu <bryan.wu at canonical.com>
>>
>> Bug: #345623
>>
>> Since commit 94cba110c064e49b437fe482dbbcb6f7b3a652d4, a remove file list was
> 
> Actually that commit was the original fold down of the debian directory
> for Jaunty so its not obviously useful to have that commit listed.  I
> would just drop this first sentence it adds nothing.
> 
>> introduced. While purging some old kernels, Matt noticed warnings from dpkg
> 
> I wouldn't quote peoples name generally.  I would just make it factual.
> 
> When purging old kernel, we see warnings from dpkg indicating that ...
> 
>> that it was not removing /lib/modules/xxx. "modules.alias.bin modules.dep.bin
>> modules.symbols.bin" 3 files are left behind.
>>
>> This patch fixes this by adding these 3 files to the prerm remove file list.
>>
>> Signed-off-by: Bryan Wu <bryan.wu at canonical.com>
>> ---
>>  debian/control-scripts/prerm |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/debian/control-scripts/prerm b/debian/control-scripts/prerm
>> index 47fbd21..4c0ad60 100644
>> --- a/debian/control-scripts/prerm
>> +++ b/debian/control-scripts/prerm
>> @@ -284,6 +284,7 @@ sub success () {
>>      modules.ieee1394map modules.pnpbiosmap
>>      modules.alias modules.ccwmap modules.inputmap
>>      modules.symbols modules.ofmap modules.seriomap
>> +    modules.alias.bin modules.dep.bin modules.symbols.bin
>>    };
>>  
>>    foreach my $extra_file (@files_to_remove) {
> 
> The patch looks technically correct.
> 
> Acked-by: Andy Whitcroft <apw at canonical.com>
> 
> -apw
> 

Totally understood. Need I resend this patch?

-- 
Bryan Wu <bryan.wu at canonical.com>
Kernel Developer    +86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com




More information about the kernel-team mailing list