[PATCH 0/1] [jaunty] LP#344370 -- Add checking for AppArmorFS creation failure.

[Amit Kucheria]

On Mon, Mar 23, 2009 at 05:25:30PM -0700, Brad Figg wrote:
> Tim Gardner wrote:
> > Brad Figg wrote:
> >> Please pull from:
> >>     git://kernel.ubuntu.com/brad/ubuntu-jaunty master
> >>
> >> Bug: 344370
> >>
> >> When the creation of the AppArmor FS fails the default_namespace is
> >> free'd. However, this was not being checked for and was being used
> >> anyway.
> >>
> >> UBUNTU: SAUCE: Add checking for AppArmorFS creation failure.
> >>
> >>  security/apparmor/main.c |    4 +++-

Could you send this AA upstream too?

> > 
> > Is this the root cause for AA oops'ing on ARM imx51 ?
> > 
> 
> Yes and no. This prevents the oops from happening. However, the
> reason this check is necessary is that earlier on the AppArmorFS
> failed to be created. The creation failed because a directory
> "apparmor" could not be created in the root directory of the
> "securityfs".
> 
> I believe that this is due to a platform configuration issue. However,
> I'm trying to figure out what the "securityfs" is, how it gets
> created and why it is missing from the imx51.

securityfs is the 4th option in 'Security Options' and it is disabled for
all ARM flavours. So it would be worth a try to just enable it and see if
the oops disappears.

If so, then instead of the above patch, the solution could be to add a
'Selected by' Kconfig dependency of AA on SECURITYFS.

Regards,
Amit

-- 
----------------------------------------------------------------------
Amit Kucheria, Kernel Engineer || amit at canonical.com
----------------------------------------------------------------------