[PATCH] UBUNTU: SAUCE: PM: Increase TEST_SUSPEND_SECONDS to avoid false kernel oops on resume

TJ ubuntu at tjworld.net
Mon Mar 23 08:43:13 UTC 2009


Bug: # 286672

This arbitrary value is intended to detect failures during resume.

The default value of 5 seconds is however likely to lead to false
reports where no failure exists. After analysing all bug reports
that had attachments with logs with the string:

 "PM: resume devices took XX seconds"

It appears there are two ranges of delays to address where no failure
occurred:

1. 5-9 seconds: usually just slightly over 5 seconds
2. 10-12 seconds: usually a result of waiting for SATA links

Setting TEST_SUSPEND_SECONDS to 12 avoids both of these ranges
causing false bug reports.
---
 kernel/power/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/power/main.c b/kernel/power/main.c
index b8f7ce9..5f73330 100644
--- a/kernel/power/main.c
+++ b/kernel/power/main.c
@@ -144,7 +144,7 @@ static inline int suspend_test(int level) { return 0; }
  * The time it takes is system-specific though, so when we test this
  * during system bootup we allow a LOT of time.
  */
-#define TEST_SUSPEND_SECONDS	5
+#define TEST_SUSPEND_SECONDS	12
 
 static unsigned long suspend_test_start_time;
 
-- 
1.6.0.4





More information about the kernel-team mailing list