[PATCH 1/1] udf: UBUNTU: SAUCE (drop after 2.6.30): Fix oops when invalid character in filename occurs

Andy Whitcroft apw at canonical.com
Thu Mar 19 12:54:02 UTC 2009


On Thu, Mar 19, 2009 at 11:46:22AM +0100, Stefan Bader wrote:
> From: Jan Kara <jack at suse.cz>
> 
> Bug: #321606
> 
> Not upstream, yet. Queued to linux-next
> 
> udf: Fix oops when invalid character in filename occurs
> 
> Functions udf_CS0toNLS() and udf_NLStoCS0() didn't count with the fact that
> NLS can return negative length when invalid character is given to it for
> conversion. Thus interesting things could happen (such as overwriting random
> memory with the rest of filename). Add appropriate checks.
> 
> Signed-off-by: Jan Kara <jack at suse.cz>
> Signed-off-by: Stefan.Bader <stefan.bader at canonical.com>

Looks sensible to me.  The first hunk was clearly wrong in the original.
Putting somethign in there seems appropriate.

Acked-by: Andy Whitcroft <apw at canonical.com>

-apw




More information about the kernel-team mailing list