[LPIA Hardy LUM] Disable RTC wake alarm to reduce power in Hibernate - attempt #3

Stefan Bader stefan.bader at canonical.com
Wed Mar 18 14:03:03 UTC 2009


Colin Ian King wrote:
> Attempt #3, aligned with comments from rtg, smb and apw.
> 
> https://bugs.launchpad.net/dennis/+bug/337943
> 
> Note: This fix comes in 2 patches, the first is general code tidyup 
> (whitespace/tab indentation, formatting) and removing a whole load of
> warnings and errors from checkpatch.
>  
> The second patch is the fix to reduce power consumption during
> hibernate.
> 
> Bug: LP#337943
> 
> LPIA Hardy Lum
> 
> Add sysfs control to enable or disable RTC Event Enable (RTC_EN) bit
> of port ACPI PM1a_EVT_BLK because the BIOS overlooked this
> functionality on the HP Mini. Disabling this before hibernate saves
> several mAh.
> 
> Note that this extends the existing power management tweaks for this
> particular netbook specific module.
> 
> Attached:
> 
> Patch 1 - code tidy up - remove a whole load of checkpatch warnings
> Patch 2 - fix to reduce power consumption
> 
> 
> 
I was about to ask whether it could be that some cleanup leaked into the new 
function part but finally realized that the index is now actually used. ;-)
I largely skipped the cleanup part. But otherwise it seems ok, lest checkpatch 
has something to say...

Stefan

-- 

When all other means of communication fail, try words!






More information about the kernel-team mailing list