[PATCH 1/1] UBUNTU: ARM Change CONFIG_PREEMPT to be not set for all ARM flavours

[Amit Kucheria]

Hi,

Patch applied with a few changes.

On Thu, Mar 12, 2009 at 12:00:05PM -0700, Brad Figg wrote:
> This email fixes the subject line of a previous request.
> 
> Brad

It is better to repeat the subject line in the email or in the patch description so that git will automatically pick up that description and it gets committed to git history. Makes it easies to go back and look.
 
> 
> Signed-off-by: Brad Figg <brad.figg at canonical.com>
> ---
>  debian/config/armel/config.imx51   |    2 +-
>  debian/config/armel/config.mv78xx0 |    2 +-
>  debian/config/armel/config.orion5x |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/debian/config/armel/config.imx51 b/debian/config/armel/config.imx51
> index a269530..f76dea4 100644
> --- a/debian/config/armel/config.imx51
> +++ b/debian/config/armel/config.imx51
> @@ -525,7 +525,7 @@ CONFIG_PM_SLEEP=y
>  CONFIG_POWER_SUPPLY=y
>  # CONFIG_POWER_SUPPLY_DEBUG is not set
>  # CONFIG_PPP is not set
> -CONFIG_PREEMPT=y
> +# CONFIG_PREEMPT is not set
>  CONFIG_PROC_EVENTS=y
>  # CONFIG_PROFILING is not set
>  # CONFIG_QC_USB is not set
> diff --git a/debian/config/armel/config.mv78xx0 b/debian/config/armel/config.mv78xx0
> index 2c6d0c7..e9c7762 100644
> --- a/debian/config/armel/config.mv78xx0
> +++ b/debian/config/armel/config.mv78xx0
> @@ -191,7 +191,7 @@ CONFIG_DEBUG_LL=y
>  # CONFIG_DEBUG_MEMORY_INIT is not set
>  # CONFIG_DEBUG_MUTEXES is not set
>  # CONFIG_DEBUG_OBJECTS is not set
> -CONFIG_DEBUG_PREEMPT=y
> +# CONFIG_DEBUG_PREEMPT is not set

You haven't actually disabled PREEMPT here. Just the DEBUG options.


>  # CONFIG_DEBUG_RT_MUTEXES is not set
>  # CONFIG_DEBUG_SG is not set
>  # CONFIG_DEBUG_SHIRQ is not set
> diff --git a/debian/config/armel/config.orion5x b/debian/config/armel/config.orion5x
> index 645e191..7f4a8a0 100644
> --- a/debian/config/armel/config.orion5x
> +++ b/debian/config/armel/config.orion5x
> @@ -228,7 +228,7 @@ CONFIG_DEBUG_LL=y
>  CONFIG_DEBUG_MEMORY_INIT=y
>  # CONFIG_DEBUG_MUTEXES is not set
>  # CONFIG_DEBUG_OBJECTS is not set
> -CONFIG_DEBUG_PREEMPT=y
> +# CONFIG_DEBUG_PREEMPT is not set

Same here.

In general, if a config option is removed from all flavours, then running updateconfigs will disable it in the flavours common config file. In this case, that would be debian/configs/armel/config. Please check the committed patch to make sure this is what you intended.

Regards,
Amit

-- 
----------------------------------------------------------------------
Amit Kucheria, Kernel Engineer || amit at canonical.com
----------------------------------------------------------------------