[PATCH 1/1] UBUNTU: SAUCE: cpufreq-nforce2: probe failures are not errors

Stefan Bader stefan.bader at canonical.com
Tue Mar 10 13:59:56 UTC 2009


Andy Whitcroft wrote:
> Bug: #332170
> 
ACK
> When we cpufreq-nforce2 fails to find the appropriate hardware it
> emits an error to indicate this.  However when this driver is built
> into the kernel this probe and fail on all non-nforce2 systems.  This
> leads us to see the following error between the BIOS and usplash:
> 
>     [    1.446954] cpufreq: No nForce2 chipset.
> 
> This error is purely informational and should not be at KERN_ERR.  Move to
> this to KERN_INFO.
> 
> A corresponding fix is already moving upstream and expected to hit 2.6.30.
> 
> Signed-off-by: Andy Whitcroft <apw at canonical.com>
> ---
>  arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c b/arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c
> index 965ea52..36090cc 100644
> --- a/arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c
> +++ b/arch/x86/kernel/cpu/cpufreq/cpufreq-nforce2.c
> @@ -420,7 +420,7 @@ static int __init nforce2_init(void)
>  
>  	/* detect chipset */
>  	if (nforce2_detect_chipset()) {
> -		printk(KERN_ERR "cpufreq: No nForce2 chipset.\n");
> +		printk(KERN_INFO "cpufreq: No nForce2 chipset.\n");
>  		return -ENODEV;
>  	}
>  


-- 

When all other means of communication fail, try words!






More information about the kernel-team mailing list