[Jaunty][PATCH] LP#193970: iwl3945: report rfkill changes event if the interface is down

[Andy Whitcroft]

On Fri, Mar 06, 2009 at 05:54:06PM +0800, Huaxu Wan wrote:
> From 6e9309361578c9bc06b05a22ef1ca05eac0b6854 Mon Sep 17 00:00:00 2001
> From: Huaxu Wan <huaxu.wan at intel.com>
> Date: Fri, 6 Mar 2009 16:18:41 +0800
> Subject: [PATCH] report rfkill changes event if interface is down
> 
> Backported from [PATCHv2] iwl3945: report killswitch changes even if the interface is down
> http://markmail.org/message/efopl4gvfrqdlzyz 
> 
> Currently iwl3945 is not able to report hw-killswitch events while the
> interface is down. This has implications on user space tools (like
> NetworkManager) relying on rfkill notifications to bring the interface
> up once the wireless gets enabled through a hw killswitch.
> 
> Thus, enable the device already in iwl3945_pci_probe instead of iwl3945_up
> and poll the CSR_GP_CNTRL register to update the killswitch state every
> two seconds. The polling is only needed on 3945 hardware as this adapter
> does not use interrupts to signal rfkill changes to the driver (in case no
> firmware is loaded). The firmware loading is still done in iwl3945_up.
> 
> Signed-off-by: Helmut Schaa <helmut.schaa at googlemail.com>
> Signed-off-by: Huaxu Wan <huaxu.wan at intel.com>

I assume that this patch is designed to fix the case where the machine is
booted with the hw kill switch on, and where the switch is subsequently
non-functional?  If so then this looks like it would be a fix for
bug #193970.

It seems to apply ok to both Jaunty and Intrepid.  I will build some test
kernels for this patch.

-apw