[LPIA Hardy LBM] mac80211: Fix debugfs file add/del for netdev

[Steve Conklin]

On 06/15/2009 09:35 AM, Colin Ian King wrote:
> Hi Stefan,
> 
> On Mon, 2009-06-15 at 15:47 +0200, Stefan Bader wrote:
>> Colin Ian King wrote:
>>> For: LPIA Hardy LBM, netbook-lpia branch
>>>
>>> LP#387235
>>>
>>> BugLink: https://bugs.launchpad.net/bugs/387235
>>>
>>> Previous version was using incorrect union structures for non-AP
>>> interfaces when adding and removing max_ratectrl_rateidx and
>>> force_unicast_rateidx entries. Depending on the vif type, this ended
>>> up in corrupting debugfs entries since the dentries inside different
>>> union structures ended up going being on top of eachother.. As the
>>> end result, debugfs files were being left behind with references to
>>> freed data (instant kernel oops on access) and directories were not
>>> removed properly when unloading mac80211 drivers. This patch fixes
>>> those issues by using only a single union structure based on the vif
>>> type.
>>>
>>> (Without this patch, debugfs entries are not deleted, causing kernel
>>> oops when they are accessed after rt73usb is removed.  This patch fixes
>>> this issue).
>>>
>>> Attached: The patch
>>>
>>>
>>>
>> ACK with two thoughts:
>> - Would this be useful for the generic disto as well?
> 
> A: Only if debugfs is enabled (which it's not - it's only enabled for
> lpia at the moment).
> 
>> - Is that still an issue upstream or has everything sufficiently changed?
>>
> A: This was backport of an upstream patch, see the note in the patch
> attached to the original email.
> 
> Colin
>> -- 
>>
>> When all other means of communication fail, try words!
>>
>>
>>

Applied