[PATCH 0/4] Karmic: Splitconfig rework to extract ubuntu-wide common configs

Tim Gardner tim.gardner at canonical.com
Fri Jun 5 06:11:35 UTC 2009


Amit Kucheria wrote:
> Hi,
> 
> This is a set of patches to split our kernel configurations into 3
> parts - Ubuntu-wide common config, Arch-wide common and flavour-specific
> config.
> 
> Patches 1 and 3 contain the code changes. Patch 2 is just a rename of
> the existing configs to the new naming scheme, while patch 4 is just a
> commit after running updateconfigs with the new code.
> 
> Regards,
> Amit
> 
> Amit Kucheria (4):
>   UBUNTU: [Config] Comment splitconfig.pl and misc cleanup
>   UBUNTU: [Config] Rename all configs to the new naming scheme
>   UBUNTU: [Config] Splitconfig rework
>   UBUNTU: [Config] Run updateconfigs after the splitconfig rework
> 
>  debian/config/amd64/config                 | 3916 --------------------------
>  debian/config/amd64/config.common.amd64    | 3444 +++++++++++++++++++++++
>  debian/config/amd64/config.flavour.generic |   15 +
>  debian/config/amd64/config.flavour.server  |   13 +
>  debian/config/amd64/config.generic         |   15 -
>  debian/config/amd64/config.server          |   13 -
>  debian/config/armel/config                 | 1450 ----------
>  debian/config/armel/config.common.armel    |  978 +++++++
>  debian/config/armel/config.flavour.imx51   |    3 +
>  debian/config/armel/config.imx51           |    3 -
>  debian/config/config.common.ubuntu         |  475 ++++
>  debian/config/i386/config                  | 4150 ----------------------------
>  debian/config/i386/config.common.i386      | 3678 ++++++++++++++++++++++++
>  debian/config/i386/config.flavour.generic  |   41 +
>  debian/config/i386/config.flavour.server   |   46 +
>  debian/config/i386/config.generic          |   41 -
>  debian/config/i386/config.server           |   46 -
>  debian/config/lpia/config                  | 3753 -------------------------
>  debian/config/lpia/config.common.lpia      | 3281 ++++++++++++++++++++++
>  debian/config/lpia/config.flavour.lpia     |    3 +
>  debian/config/lpia/config.lpia             |    3 -
>  debian/rules.d/1-maintainer.mk             |    6 +-
>  debian/scripts/misc/oldconfig              |  125 +-
>  debian/scripts/misc/splitconfig.pl         |   20 +-
>  24 files changed, 12066 insertions(+), 13452 deletions(-)
>  delete mode 100644 debian/config/amd64/config
>  create mode 100644 debian/config/amd64/config.common.amd64
>  create mode 100644 debian/config/amd64/config.flavour.generic
>  create mode 100644 debian/config/amd64/config.flavour.server
>  delete mode 100644 debian/config/amd64/config.generic
>  delete mode 100644 debian/config/amd64/config.server
>  delete mode 100644 debian/config/armel/config
>  create mode 100644 debian/config/armel/config.common.armel
>  create mode 100644 debian/config/armel/config.flavour.imx51
>  delete mode 100644 debian/config/armel/config.imx51
>  create mode 100644 debian/config/config.common.ubuntu
>  delete mode 100644 debian/config/i386/config
>  create mode 100644 debian/config/i386/config.common.i386
>  create mode 100644 debian/config/i386/config.flavour.generic
>  create mode 100644 debian/config/i386/config.flavour.server
>  delete mode 100644 debian/config/i386/config.generic
>  delete mode 100644 debian/config/i386/config.server
>  delete mode 100644 debian/config/lpia/config
>  create mode 100644 debian/config/lpia/config.common.lpia
>  create mode 100644 debian/config/lpia/config.flavour.lpia
>  delete mode 100644 debian/config/lpia/config.lpia
> 
> 

I like the implementation, though I think you'll have to redo the rename 
patches against Andy's most recent upload. I applied your patches 
locally (with some futzing) and reran updateconfigs, but ended up with 
an empty config.common.ubuntu.

I'd say just commit the changes as soon as you are comfortable that they 
produce the same configs as before.

rtg
-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list