[PATCH] UBUNTU: [arm] Fix kexec on ARM by properly calling the relocation function

Russell King - ARM Linux linux at arm.linux.org.uk
Sat Jan 24 20:10:33 GMT 2009


On Sat, Jan 24, 2009 at 08:02:59PM +0000, Russell King - ARM Linux wrote:
> On Thu, Jan 22, 2009 at 10:33:39AM +0200, Amit Kucheria wrote:
> > Forwarding a patch to fix kexec on ARM. Comments sought.
> 
> This patch can't work - with how it is, you'll be booting a kernel with
> the CPU MMU enabled.  Kernels must be booted with the CPU MMU disabled
> as per the 'booting.txt' documentation, which can be found in the kernel
> source and on my website.
> 
> In fact, this patch looks entirely bogus.  The reboot code
> (arch/arm/kernel/relocate_kernel.S) does not take any arguments - in
> fact, the first two instructions load into r0,r1 which, if arguments
> were passed, would wipe out the first two arguments.
> 
> So no, this patch looks bogus.

And having looked at the ubuntu git tree, relocate_kernel.S is no
different from the mainline version.  So this patch is definitely
bogus.



More information about the kernel-team mailing list