[PATCH] replace sync_page_range() with generic_write_sync() in file-io.c

[Tim Gardner]

John Johansen wrote:
> Manoj Iyer wrote:
>> ----
>> resending patch, my previous mail bounced coz of membership requirement
>> ----
>>
>> sync_page_range() was recently removed from 2.6, this causes the
>> iscsi-target build to fail in file-io.c. possibly sync_page_range() can be
>> replaced with generic_write_sync() ?
>>
> yeah they basically do the same thing though it looks like generic_write_sync
> can be heavier than what is needed in some cases.  See
> http://lkml.org/lkml/2009/8/19/330
> 
> I haven't followed through to check whether this is the case with iscsi-target
> yet.
> 

Seems to me that we should use filemap_write_and_wait_range() in order
to preserve the intended semantics of the original call to
sync_page_range(). Since this is a network protocol, we don't want file
pages getting cached, or is my interpretation too naive?

rtg
-- 
Tim Gardner tim.gardner at canonical.com