[PATCH 1/2] [Jaunty] UBUNTU: ext4: Print the find_group_flex() warning only once

Leann Ogasawara leann.ogasawara at canonical.com
Mon Aug 31 22:46:37 UTC 2009


>From c516b187ec131e59cff4d00fdfb0b823f2e13635 Mon Sep 17 00:00:00 2001
From: Theodore Ts'o <tytso at mit.edu>
Date: Thu, 12 Mar 2009 12:20:01 -0400
Subject: [PATCH 1/2] ext4: Print the find_group_flex() warning only once

upstream commit 2842c3b5449f31470b61db716f1926b594fb6156

BugLink: http://bugs.launchpad.net/bugs/367065

This is a short-term warning, and even printk_ratelimit() can result
in too much noise in system logs.  So only print it once as a warning.

Signed-off-by: "Theodore Ts'o" <tytso at mit.edu>
Signed-off-by: Leann Ogasawara <leann.ogasawara at canonical.com>
---
 fs/ext4/ialloc.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 03c0819..e04c45d 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -686,6 +686,7 @@ struct inode *ext4_new_inode(handle_t *handle, struct inode *dir, int mode)
 	struct inode *ret;
 	ext4_group_t i;
 	int free = 0;
+	static int once = 1;
 	ext4_group_t flex_group;
 
 	/* Cannot create files in a deleted directory */
@@ -705,7 +706,8 @@ struct inode *ext4_new_inode(handle_t *handle, struct inode *dir, int mode)
 		ret2 = find_group_flex(sb, dir, &group);
 		if (ret2 == -1) {
 			ret2 = find_group_other(sb, dir, &group);
-			if (ret2 == 0 && printk_ratelimit())
+			if (ret2 == 0 && once)
+				once = 0;
 				printk(KERN_NOTICE "ext4: find_group_flex "
 				       "failed, fallback succeeded dir %lu\n",
 				       dir->i_ino);
-- 
1.6.3.3






More information about the kernel-team mailing list