[PATCH] [Hardy] UBUNTU: Enable multicast routing (including PIM1 and PIM2) for sparc

Tim Gardner tim.gardner at canonical.com
Wed Aug 26 15:33:51 UTC 2009


Stefan Bader wrote:
> Tim Gardner wrote:
>> Leann Ogasawara wrote:
>>> SRU Justification:
>>>
>>> Impact: In Hardy, multicast routing is not supported on sparc
>>>
>>> Fix: Enable the following sparc kernel config options:
>>>
>>> CONFIG_IP_MROUTE=y (default is not set)
>>> CONFIG_IP_PIMSM_V1=y
>>> CONFIG_IP_PIMSM_V2=y
>>>
>>> Testcase: Install and run a sparc Hardy kernel and confirm that
>>> multicast routing is not supported (including PIM1 and PIM2). Install
>>> the patched sparc Hardy kernel, reboot, and confirm multicast routing is
>>> now supported.
>>>
>>> Fabio, has tested and confirmed that enabling the above sparc config
>>> options resolves this issue for him him.
>>> The following changes since commit
>>> b03f820aa90992594689c258be2c695c91b35c0b:
>>>   Stefan Bader (1):
>>>         UBUNTU: Ubuntu-2.6.24-24.60
>>>
>>> are available in the git repository at:
>>>
>>>   git://kernel.ubuntu.com/ogasawara/ubuntu-hardy.git lp416266
>>>
>>> Leann Ogasawara (1):
>>>       UBUNTU: Enable multicast routing (including PIM1 and PIM2) for
>>> sparc
>>>
>>>  debian/config/sparc/config |    4 +++-
>>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>>
>>> >From 369cb42b4c8b92f7648876d386fa4b2b3a450793 Mon Sep 17 00:00:00 2001
>>> From: Leann Ogasawara <leann.ogasawara at canonical.com>
>>> Date: Mon, 24 Aug 2009 16:01:03 -0700
>>> Subject: [PATCH] UBUNTU: Enable multicast routing (including PIM1 and
>>> PIM2) for sparc
>>>
>>> BugLink: http://bugs.launchpad.net/bugs/416266
>>>
>>> It was discovered that multicast routing (including PIM1 and PIM2)
>>> for sparc was not enabled.  Enable these for sparc.
>>>
>>> Signed-off-by: Leann Ogasawara <leann.ogasawara at canonical.com>
>>> ---
>>>  debian/config/sparc/config |    4 +++-
>>>  1 files changed, 3 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/debian/config/sparc/config b/debian/config/sparc/config
>>> index c64c592..95277c0 100644
>>> --- a/debian/config/sparc/config
>>> +++ b/debian/config/sparc/config
>>> @@ -769,7 +769,7 @@ CONFIG_IP_DCCP_CCID3_RTO=100
>>>  CONFIG_IP_DCCP_TFRC_LIB=m
>>>  CONFIG_IP_FIB_HASH=y
>>>  # CONFIG_IP_FIB_TRIE is not set
>>> -# CONFIG_IP_MROUTE is not set
>>> +CONFIG_IP_MROUTE=y
>>>  CONFIG_IP_MULTICAST=y
>>>  CONFIG_IP_MULTIPLE_TABLES=y
>>>  CONFIG_IP_NF_ARPFILTER=m
>>> @@ -799,6 +799,8 @@ CONFIG_IP_NF_TARGET_SAME=m
>>>  CONFIG_IP_NF_TARGET_TOS=m
>>>  CONFIG_IP_NF_TARGET_TTL=m
>>>  CONFIG_IP_NF_TARGET_ULOG=m
>>> +CONFIG_IP_PIMSM_V1=y
>>> +CONFIG_IP_PIMSM_V2=y
>>>  CONFIG_IP_PNP=y
>>>  # CONFIG_IP_PNP_BOOTP is not set
>>>  # CONFIG_IP_PNP_DHCP is not set
>>
>> Is there any reason not to do the same for ia64 and hppa? Its one of
>> those common settings that should be the same for all architectures.
> 
> Probably the only reason is not to touch things we were not asked to
> touch in the first place. For sparc Fabbione actually wants it and also
> has tested the setup. For the other archs, I would tend to wait until
> someone misses the feature.
> 

I have to agree with Fabio. Arch independent, distro common settings
_should_ be the same for all flavours. In fact, it could be considered a
regression in that this feature is _not_ enabled for hppa and ia64
(though I doubt any of these platforms are being used as border gateway
routers).

>> Maybe we ought to think about retrofitting Hardy with the same config
>> algorithm that we're using in Karmic (buts thats a bug for another time).
>>
>> debian/config/powerpc/config:CONFIG_IP_MROUTE=y
>> debian/config/i386/config:CONFIG_IP_MROUTE=y
>> debian/config/amd64/config:CONFIG_IP_MROUTE=y
>> debian/config/hppa/config:# CONFIG_IP_MROUTE is not set
>> debian/config/ia64/config:# CONFIG_IP_MROUTE is not set
>> debian/config/sparc/config:# CONFIG_IP_MROUTE is not set
>>
>> rtg
> 
> 


-- 
Tim Gardner tim.gardner at canonical.com




More information about the kernel-team mailing list