[PATCH 0/1] UBUNTU: Add hdaps_ec driver to support newer ThinkPads (Hard Drive Active Protection System)

[Tim Gardner]

Brad Figg wrote:
> Please pull from :
>     git://kernel.ubuntu.com/bradf/ubuntu-karmic master
> 
> Bug: #297213
> 
> Hardy had two drivers which handled the HardDisk Active
> Protection System (hdaps and hdaps_ec) which is present in IBM
> ThinkPads.  One of the two drivers was dropped when Intrepid
> development began and due to that there are a number of ThinkPads
> (newer models) for which this is not supported.
> 
> This patch brings back in the missing driver.
> 
> The code for this patch was taken from http://tpctl.sourceforge.net
> and is the 0.40 release of December 16, 2008.
> 
> Brad Figg (1):
>   UBUNTU: Add hdaps_ec driver to support newer ThinkPads (Hard Drive
>     Active Protection System)
> 
>  ubuntu/misc/Kconfig    |   13 +
>  ubuntu/misc/Makefile   |    2 +-
>  ubuntu/misc/hdaps_ec.c |  880 ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 894 insertions(+), 1 deletions(-)
>  create mode 100644 ubuntu/misc/hdaps_ec.c
> 
> 

How is this one better then drivers/hwmon/hdaps.c ? The in-kernel driver 
appears to contain a superset of DMI table information, i.e., supported 
platforms. Furthermore, it corrects some problems that exist in 
ubuntu/misc/hdaps_ec.c, such as I/O space registration, only loads if at 
least one DMI match is found, and uses in-kernel functionality for 
polled input devices.

So, NAK from me unless you can convince me otherwise.

rtg
-- 
Tim Gardner tim.gardner at canonical.com